Earle, I saw on the dev wiki http://openguides.org/dev/?node=Earle's%20To-Do that you want to move it. But why does it need to exist at all? It can be done entirely within the templates:
[% IF latitude AND longitude %] <a href="http://www.geocaching.com/seek/nearest_cache.asp?origin_lat=[% latitude %]&origin_long=[% longitude %]">Look for nearby geocaches</a> [% END %]
Cheers,
Dominic.
On Wed, Jun 09, 2004 at 12:41:45AM +0100, Dominic Hargreaves wrote:
But why does it need to exist at all? It can be done entirely within the templates:
*blink* Good question! You're completely right; I have no idea why it exists as a plugin. Presumably as the result of some conversation or other around the time of the first hackfest. I'll patch the templates when I have a moment today, and when the next version's been released I'll deprecate the module.
On Wed 09 Jun 2004, Earle Martin openguides@downlode.org wrote:
*blink* Good question! You're completely right; I have no idea why it exists as a plugin.
I think you were planning to change it so it only needed the name of a node and it would go and find out the latitude and longitude by itself; the usefulness of having it as a module was in case the URL of the geocaching thingy changed.
But yes, reducing our prerequisites is a good thing. I have also been thinking about changing the RSS reader plugin to optional - it's certainly a nice thing, but it's not essential to getting a guide up and running. Perhaps Test::MockObject should be optional too and we can just skip the tests that need it if it's not installed.
Kake
On Wed, Jun 09, 2004 at 12:01:43PM +0100, Kate L Pugh wrote:
I think you were planning to change it so it only needed the name of a node and it would go and find out the latitude and longitude by itself; the usefulness of having it as a module was in case the URL of the geocaching thingy changed.
What would be even better would be a configuration variable, for some future version:
geocaching_link = http://www.geocaching.com/seek/nearest_cache.asp?origin_lat=%5B% latitude %]&origin_long=[% longitude %]
and by extension
mapping_link = http://www.streetmap.co.uk/streetmap.dll?grid2map?%5B% os_x%]&[% os_y %]&arrow=yes
Or, I suppose, to split those out into tiny .tt files of their own. Hmm.
Dominic.
On Wed 09 Jun 2004, Dominic Hargreaves dom@earth.li wrote:
What would be even better would be a configuration variable, for some future version:
geocaching_link = http://www.geocaching.com/seek/nearest_cache.asp?origin_lat=%5B% latitude %]&origin_long=[% longitude %]
I think this is better set centrally - after all, if the URL *does* change then it's easier for us to just make the change in the distro than for everyone to have to edit their config files.
Kake
On Wed, Jun 09, 2004 at 12:35:55PM +0100, Kate L Pugh wrote:
On Wed 09 Jun 2004, Dominic Hargreaves dom@earth.li wrote:
What would be even better would be a configuration variable, for some future version:
geocaching_link = http://www.geocaching.com/seek/nearest_cache.asp?origin_lat=%5B% latitude %]&origin_long=[% longitude %]
I think this is better set centrally - after all, if the URL *does* change then it's easier for us to just make the change in the distro than for everyone to have to edit their config files.
For geocaching where this is a well-defined thing, yes. However for mapping it seems to be a lot more down to personal preference and location. I'd like to add the automapping URLs to CVS, but it doesn't seem worth hardcoding streetmap in that case.
Dominic.
On Wed, 2004-06-09 at 08:35, Kate L Pugh wrote:
geocaching_link = http://www.geocaching.com/seek/nearest_cache.asp?origin_lat=%5B% latitude %]&origin_long=[% longitude %]
I think this is better set centrally - after all, if the URL *does* change then it's easier for us to just make the change in the distro than for everyone to have to edit their config files.
IMHO, there is not a good idea to have any URI hardcoded, when you can always have it in the config files or the templates
On Wed, Jun 09, 2004 at 08:49:10AM +0100, Earle Martin wrote:
On Wed, Jun 09, 2004 at 12:41:45AM +0100, Dominic Hargreaves wrote:
But why does it need to exist at all? It can be done entirely within the templates:
*blink* Good question! You're completely right; I have no idea why it exists as a plugin. Presumably as the result of some conversation or other around the time of the first hackfest. I'll patch the templates when I have a moment today, and when the next version's been released I'll deprecate the module.
Hello,
I notice that this has not yet happened. Do you plan to do this soon? I'd quite like to resolve this before starting the process of getting my Debian packages into Debian, to avoid unnecessary cruft.
Cheers,
Dominic.
On Tue, Oct 12, 2004 at 12:02:24AM +0100, Dominic Hargreaves wrote:
[ replace GeoCache.pm with template code ]
I notice that this has not yet happened. Do you plan to do this soon?
I've just done it, so it'll be in 0.42. I'm going to release a new version of GeoCache.pm with a big "DEPRECATED, upgrade to OpenGuides 0.42 or better" (although it'll still work) as soon as I can find someone who can fiddle with cvs on un - I'm getting cvs update: failed to obtain dir lock in repository /var/lib/cvs/cgi-wiki-plugin-geocache'. Anyway, your changes are committed (you can see them in action on my flaky dev wiki at http://un.earth.li/~earle/cgi-bin/wiki.cgi?Test_Node_2).
openguides-dev@lists.openguides.org
-
Dominic Hargreaves -
Earle Martin -
Kate L Pugh -
Martín Ferrari