On Sun, Apr 21, 2013 at 09:51:28AM +0100, Dominic Hargreaves wrote:
[moving to openguides-dev]
On Sun, Apr 21, 2013 at 08:06:31AM +0100, Kake wrote:
On Sat 20 Apr 2013, Dominic Hargreaves dom@earth.li wrote:
https://github.com/OpenGuides/OpenGuides/commit/111c9339858fad183cabde469518...
Nice! Would it be better to do it the other way around? As it stands, to use this in RGL/CGC I'd have to go through and remove all the map links from the data. Could we INCLUDE custom_auto_map_link.tt by default, and fall back to map_link only if there isn't one? Also, it might be better to call the template custom_auto_map_links.tt, since I at least will want to put in more than one map link.
Okay. The logic is right for Oxford, because we assume that if a map link is provided, it's more interesting than a generic one. But the Oxford custom template can easily replicate that functionality.
Also, I'd like to see some tests for this new feature, as with all new features.
Okay.
This is back on my list.
Updated to provide more flexibility and with tests:
https://github.com/OpenGuides/OpenGuides/pull/54
http://dev.openguides.org/browser/sites/oxford.openguides.org/templates/cust...