Checking out a fresh "grubclone" on un, I get the following in ./Build test:
t/13_cookies........................1..16 ok 1 - use OpenGuides::CGI; ok 2 - ->make_prefs_cookie dies if no config object supplied ok 3 - ...or if config isn't a Config::Tiny ok 4 - ...but not if it is ok 5 - ->make_prefs_cookie returns a cookie isa CGI::Cookie ok 6 - ->get_prefs_from_cookie dies if no config object supplied ok 7 - ...or if config isn't a Config::Tiny ok 8 - ...but not if it is ok 9 - get_prefs_from_cookie can find username ok 10 - ...and geocache prefs ok 11 - ...and preview prefs ok 12 - ...and latlong prefs not ok 13 - ...and formatting link prefs # Failed test (t/13_cookies.t at line 46) # got: undef # expected: '1' ok 14 - ...and minor edits prefs ok 15 - ->get_prefs_from_cookie doesn't die if no cookie set ok 16 - ...and returns six default values # Looks like you failed 1 tests of 16. dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 13 Failed 1/16 tests, 93.75% okay
================= Also, I have applied a change to wiki.cgi, to use CGI::Wiki::Plugin::Diff instead of OpenGuides::Diff. (but not removed Diff.pm from the dist yet).
t/51_diff.t uses OG::D and uses some stuff with mock objects. Do we need any tests for diff inside OG, as C::W::P::D has its own tests?
btw, should I have changed the version number to 030_02?
Ivor.
On Sat 13 Dec 2003, Ivor Williams ivor.williams@tiscali.co.uk wrote:
Checking out a fresh "grubclone" on un, I get the following in ./Build test:
t/13_cookies........................1..16 [...] not ok 13 - ...and formatting link prefs # Failed test (t/13_cookies.t at line 46) # got: undef # expected: '1'
Earle?
Kake
On Mon, Dec 15, 2003 at 09:27:03AM +0000, Kate L Pugh wrote:
On Sat 13 Dec 2003, Ivor Williams ivor.williams@tiscali.co.uk wrote:
Checking out a fresh "grubclone" on un... not ok 13 - ...and formatting link prefs
Earle?
Got it - passes for me now, please check.
On Sat 13 Dec 2003, Ivor Williams ivor.williams@tiscali.co.uk wrote:
Checking out a fresh "grubclone" on un... not ok 13 - ...and formatting link prefs
On Mon 15 Dec 2003, Earle Martin openguides@downlode.org wrote:
Got it - passes for me now, please check.
I think you mean "sorry auntie Kake, I will never again check things in without running the tests"?
:)
auntie Kake
openguides-dev@lists.openguides.org