Some work's been done on this - see http://dev.openguides.org/ticket/81 - and I'm just looking for comments on this change really. PerfDave, do can you explain you reason for wanting this? I think it'll help me understand the value of having it if so. One thing would be for translation purposes, I suppose?
Cheers,
Dominic.
Dominic Hargreaves wrote:
Some work's been done on this - see http://dev.openguides.org/ticket/81
- and I'm just looking for comments on this change really. PerfDave, do
can you explain you reason for wanting this? I think it'll help me understand the value of having it if so. One thing would be for translation purposes, I suppose?
My personal interest is in disabling the prefixes entirely. I'm running into situations where Category Foo is just a @REDIRECT to Foo, or vice-versa, and the same applies to Locales. I don't see any reason to prefix the node names with "Category" or "Locale" when that information is presented by whether the node is in category "Category" or category "Locale".
The node http://manchester.openguides.org/?Category_Hitching indicates that people are confused by the prefixes. Category Hitching is not a category, it's just a node with that name in front. I suspect it's called that because the other links in http://manchester.openguides.org/?Category_Transport all start with "Category" and the user was merely following suit.
I don't see that dropping prefixes will do any harm, other than the hassle of refactoring the database for *existing* guides, and I think it will make OpenGuides more usable. However, when it came to implementing it, I saw #53 and decided to make the prefix a customisable string rather than a boolean, since I was mucking around with the code anyway.
Dave
Dave Page wrote:
The node http://manchester.openguides.org/?Category_Hitching indicates that people are confused by the prefixes. Category Hitching is not a category, it's just a node with that name in front. I suspect it's called that because the other links in http://manchester.openguides.org/?Category_Transport all start with "Category" and the user was merely following suit.
Oh, and it'll save all the hassle of writing [[Category Foo|Foo]] every time you want to construct a coherent paragraph which contains a link to a category ;)
Dave
On Wed, Feb 22, 2006 at 10:26:13PM +0000, Dave Page wrote:
My personal interest is in disabling the prefixes entirely. I'm running into situations where Category Foo is just a @REDIRECT to Foo, or vice-versa, and the same applies to Locales. I don't see any reason to prefix the node names with "Category" or "Locale" when that information is presented by whether the node is in category "Category" or category "Locale".
Okay, thanks for that explanation. I've got a few comments on the patch itself (http://dev.openguides.org/attachment/ticket/81/ticket_81.patch)
trunk/lib/OpenGuides/Config.pm new lines 87-88 - if Config::Tiny doesn't accept spaces, presumably this default shouldn't have spaces either for consistency. Will the code always append trailing spaces, or only if there isn't already one?
trunk/lib/OpenGuides.pm old lines 150-159 - I'm not sure why you're removing this. Can you explain? new lines 506-516 - surely you need to set $type_prefix depending on the value of $args{type} rather than just setting it to $config->category_prefix?
I assume that the test suite passes all tests with this patch, and you've tested the functionality you've added? In fact, could you add a test for the functionality itself?
Cheers,
Dominic.
openguides-dev@lists.openguides.org
-
Dave Page -
Dominic Hargreaves