if you search from http://openguides.org/london/supersearch.cgi you get a page not found
----- Original Message ----- From: "Bob Walker" bob@randomness.org.uk To: openguides-dev@openguides.org Sent: 08 August 2003 17:47 Subject: [OpenGuides-Dev] bug in search
if you search from http://openguides.org/london/supersearch.cgi you get a page not found
Interesting... I've noticed that the search box on the Supersearch page is broken, and I've just done some more digging to find that:
I don't get the problem on un.earth.li The Oxford site seems to work correctly.
Anyway, the technical details are as follows:
The HTML is being generated by CGI.pm, in particular start_form, which has not been supplied with an -action parameter, hence it sould reinvoke the same script with a new query string.
What we are seeing is that something has munged forward slashes into %2F - but we want real forward slashes! This is getting prepended with http://openguides.org/london/ resulting in a mess.
Any idea where this extra munging is coming from? It could be that there are different versions of CGI.pm floating around.
I cannot reproduce the problem outside of OG London.
Help please.
Ivor.
On Sat 09 Aug 2003, Ivor Williams ivor.williams@tiscali.co.uk wrote:
The HTML is being generated by CGI.pm, in particular start_form, which has not been supplied with an -action parameter, hence it sould reinvoke the same script with a new query string.
What we are seeing is that something has munged forward slashes into %2F - but we want real forward slashes! This is getting prepended with http://openguides.org/london/ resulting in a mess.
Any idea where this extra munging is coming from? It could be that there are different versions of CGI.pm floating around.
Try running supersearch.cgi under CGI.pm 2.99 (the latest) and 2.98, and you will see that it works right with 2.98 but not 2.99.
In general I would suggest not using CGI.pm unless it's absolutely necessary. Just write the HTML in a TT template. Ivor, are you going to get time soon to fix the search or should I add it to my to-do list?
Kake
----- Original Message ----- From: "Kate L Pugh" kake@earth.li To: openguides-dev@openguides.org Sent: 12 August 2003 14:25 Subject: Re: [OpenGuides-Dev] bug in search
On Sat 09 Aug 2003, Ivor Williams ivor.williams@tiscali.co.uk wrote:
The HTML is being generated by CGI.pm, in particular start_form, which has not been supplied with an -action parameter, hence it sould reinvoke the same script with a new query string.
What we are seeing is that something has munged forward slashes into %2F - but we want real forward slashes! This is getting prepended with http://openguides.org/london/ resulting in a mess.
Any idea where this extra munging is coming from? It could be that there are different versions of CGI.pm floating around.
Try running supersearch.cgi under CGI.pm 2.99 (the latest) and 2.98, and you will see that it works right with 2.98 but not 2.99.
In general I would suggest not using CGI.pm unless it's absolutely necessary. Just write the HTML in a TT template. Ivor, are you going to get time soon to fix the search or should I add it to my to-do list?
I seriously intend to do this. Fixing supersearch is top of the list of things for OpenGuides. So I'll get onto it.
Ivor.
On Wed 13 Aug 2003, Ivor Williams ivor.williams@tiscali.co.uk wrote:
I seriously intend to do this. Fixing supersearch is top of the list of things for OpenGuides. So I'll get onto it.
How is this coming along?
Kake
From: "Kate L Pugh" kake@earth.li:
In general I would suggest not using CGI.pm unless it's absolutely necessary. Just write the HTML in a TT template. Ivor, are you going to get time soon to fix the search or should I add it to my to-do list?
On Wed 13 Aug 2003, Ivor Williams ivor.williams@tiscali.co.uk wrote:
I seriously intend to do this. Fixing supersearch is top of the list of things for OpenGuides. So I'll get onto it.
I got itchy about how long this has been broken for, and so I JFDI and reworked supersearch.cgi into a module (OpenGuides::SuperSearch), a template, and a very short CGI script that just calls the ->run method on the module. There are of course tests as well. I've checked all this into CVS on un and would appreciate it if Ivor could have a look at it. I'd like to release this within the next couple of days, preferably tomorrow. Tonight would be even better but I appreciate that Ivor doesn't get online too much.
People without un accounts can see the tarball here, but note this is a temp directory and once this release is on CPAN I'll delete the temporary one: http://the.earth.li/~kake/tmp/OpenGuides-0.24.tar.gz You can see this version of OpenGuides in action at http://un.earth.li/~kake/cgi-bin/wiki.cgi
The refactor of the search is the major change between this version and the live one.
Kake
openguides-dev@lists.openguides.org
-
Bob Walker -
Ivor Williams -
Kate L Pugh