I currently have t/53 failing due to WGS84 coords not being
calculated. I traced this back to Geo::HelmertTransform failing due to
it not being installed.
I was going to patch this but wanted to check first. My initial
thought was if the force_wgs84 param is set to 0 (no) during perl
Build.PL then the Geo::HelmertTransform requirement should be added to
the build requires section. Something ditto for
Geography::NationalGrid::(IE|GB). What say ye?
Also, I'd like to see $@ tested after the transformation; I have that
as a die in my local source right now. It's at the least irritating
having silent failures requiring source spelunking.
As an aside it made me wonder whether force_wgs84 = 1 is a more
appropriate default given that it doesn't seem to matter much, and
it's an optimisation away from performing the transform. I really
havent looked at the code all that much though so this might not be a
sensible comment.
I have a few other random patches against trunk sitting here; who'd like 'em?
Paul