openguides-commits

openguides-commits@lists.openguides.org

873 discussions

r1324 - branches/rel_0_66/t
by svnadmin＠urchin.earth.li 05 Apr '12

05 Apr '12

Author: bob Date: 2012-04-05 09:04:20 +0100 (Thu, 05 Apr 2012) New Revision: 1324 Modified: branches/rel_0_66/t/25_write_geo_data.t branches/rel_0_66/t/26_geo_data_search_form.t branches/rel_0_66/t/27_geo_data_edit_form.t branches/rel_0_66/t/33_search_advanced_search.t branches/rel_0_66/t/33_search_advanced_search_utm.t branches/rel_0_66/t/34_search_paging.t branches/rel_0_66/t/35_search_two_searches.t branches/rel_0_66/t/38_search_params.t branches/rel_0_66/t/39_search_form.t branches/rel_0_66/t/62_bug_trailing_whitespace.t branches/rel_0_66/t/66_bug_latlong_representation.t branches/rel_0_66/t/69_bug_zero_geo.t Log: now we require all 3 Geo Modules we should no longer skip tests if any of them are missing. Modified: branches/rel_0_66/t/25_write_geo_data.t =================================================================== --- branches/rel_0_66/t/25_write_geo_data.t 2012-04-05 07:37:12 UTC (rev 1323) +++ branches/rel_0_66/t/25_write_geo_data.t 2012-04-05 08:04:20 UTC (rev 1324) @@ -16,25 +16,6 @@ plan skip_all => "Plucene not installed"; } -# Strictly speaking we don't need to skip _all_ tests if we don't have -# the modules below. Revisit this when not in a hurry. -# We only actually need the former two for the National Grid tests and the -# latter for the UTM tests. -eval { require Geo::Coordinates::OSGB; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::OSGB not installed"; -} - -eval { require Geo::Coordinates::ITM; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::ITM not installed"; -} - -eval { require Geo::Coordinates::UTM; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::UTM not installed"; -} - plan tests => 53; # Clear out the database from any previous runs. Modified: branches/rel_0_66/t/26_geo_data_search_form.t =================================================================== --- branches/rel_0_66/t/26_geo_data_search_form.t 2012-04-05 07:37:12 UTC (rev 1323) +++ branches/rel_0_66/t/26_geo_data_search_form.t 2012-04-05 08:04:20 UTC (rev 1324) @@ -20,25 +20,6 @@ plan skip_all => "Test::HTML::Content not installed"; } -# Strictly speaking we don't need to skip _all_ tests if we don't have -# the modules below. Revisit this when not in a hurry. -# We only actually need the former two for the National Grid tests and the -# latter for the UTM tests. -eval { require Geo::Coordinates::OSGB; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::OSGB not installed"; -} - -eval { require Geo::Coordinates::ITM; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::ITM not installed"; -} - -eval { require Geo::Coordinates::UTM; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::UTM not installed"; -} - plan tests => 12; # Clear out the database from any previous runs. Modified: branches/rel_0_66/t/27_geo_data_edit_form.t =================================================================== --- branches/rel_0_66/t/27_geo_data_edit_form.t 2012-04-05 07:37:12 UTC (rev 1323) +++ branches/rel_0_66/t/27_geo_data_edit_form.t 2012-04-05 08:04:20 UTC (rev 1324) @@ -20,25 +20,6 @@ plan skip_all => "Test::HTML::Content not installed"; } -# Strictly speaking we don't need to skip _all_ tests if we don't have -# the modules below. Revisit this when not in a hurry. -# We only actually need the former two for the National Grid tests and the -# latter for the UTM tests. -eval { require Geo::Coordinates::OSGB; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::OSGB not installed"; -} - -eval { require Geo::Coordinates::ITM; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::ITM not installed"; -} - -eval { require Geo::Coordinates::UTM; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::UTM not installed"; -} - plan tests => 18; # Clear out the database from any previous runs. Modified: branches/rel_0_66/t/33_search_advanced_search.t =================================================================== --- branches/rel_0_66/t/33_search_advanced_search.t 2012-04-05 07:37:12 UTC (rev 1323) +++ branches/rel_0_66/t/33_search_advanced_search.t 2012-04-05 08:04:20 UTC (rev 1324) @@ -17,10 +17,6 @@ plan skip_all => "Plucene not installed"; } -eval { require Geo::Coordinates::OSGB; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::OSGB not installed"; -} plan tests => 8; Modified: branches/rel_0_66/t/33_search_advanced_search_utm.t =================================================================== --- branches/rel_0_66/t/33_search_advanced_search_utm.t 2012-04-05 07:37:12 UTC (rev 1323) +++ branches/rel_0_66/t/33_search_advanced_search_utm.t 2012-04-05 08:04:20 UTC (rev 1324) @@ -16,11 +16,6 @@ plan skip_all => "Plucene not installed"; } -eval { require Geo::Coordinates::UTM; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::UTM not installed"; -} - plan tests => 4; # Clear out the database from any previous runs. Modified: branches/rel_0_66/t/34_search_paging.t =================================================================== --- branches/rel_0_66/t/34_search_paging.t 2012-04-05 07:37:12 UTC (rev 1323) +++ branches/rel_0_66/t/34_search_paging.t 2012-04-05 08:04:20 UTC (rev 1324) @@ -28,9 +28,6 @@ my $guide = OpenGuides->new( config => $config ); # Test with OS co-ords. -eval { require Geo::Coordinates::OSGB; }; -SKIP: { - skip "Geo::Coordinates::OSGB not installed", 6 if $@; $config->geo_handler( 1 ); foreach my $i ( 1 .. 50 ) { @@ -64,12 +61,8 @@ "os_y retained in previous page link" ); like( $output, qr/search.cgi\?.*os_dist=1500.*Previous.*results/s, "os_dist retained in previous page link" ); -} # Test with OSIE co-ords. -eval { require Geo::Coordinates::ITM; }; -SKIP: { - skip "Geo::Coordinates::ITM not installed", 6 if $@; # We must create a new search object after changing the geo_handler # in order to force it to create a fresh locator. @@ -106,12 +99,8 @@ "osie_y retained in previous page link" ); like( $output, qr/search.cgi\?.*osie_dist=1500.*Previous.*results/s, "osie_dist retained in previous page link" ); -} # Test with UTM. -eval { require Geo::Coordinates::UTM; }; -SKIP: { - skip "Geo::Coordinates::UTM not installed", 6 if $@; # We must create a new search object after changing the geo_handler # in order to force it to create a fresh locator. @@ -148,4 +137,3 @@ "longitude retained in previous page link" ); like( $output, qr/search.cgi\?.*latlong_dist=1500.*Previous.*results/s, "latlong_dist retained in previous page link" ); -} Modified: branches/rel_0_66/t/35_search_two_searches.t =================================================================== --- branches/rel_0_66/t/35_search_two_searches.t 2012-04-05 07:37:12 UTC (rev 1323) +++ branches/rel_0_66/t/35_search_two_searches.t 2012-04-05 08:04:20 UTC (rev 1324) @@ -16,25 +16,7 @@ plan skip_all => "Plucene not installed"; } -# Strictly speaking we don't need to skip _all_ tests if we don't have -# the modules below. Revisit this when not in a hurry. -# We only actually need the former two for the National Grid tests and the -# latter for the UTM tests. -eval { require Geo::Coordinates::OSGB; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::OSGB not installed"; -} -eval { require Geo::Coordinates::ITM; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::ITM not installed"; -} - -eval { require Geo::Coordinates::UTM; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::UTM not installed"; -} - plan tests => 10; # Clear out the database from any previous runs. Modified: branches/rel_0_66/t/38_search_params.t =================================================================== --- branches/rel_0_66/t/38_search_params.t 2012-04-05 07:37:12 UTC (rev 1323) +++ branches/rel_0_66/t/38_search_params.t 2012-04-05 08:04:20 UTC (rev 1324) @@ -17,25 +17,6 @@ plan skip_all => "Plucene not installed"; } -# Strictly speaking we don't need to skip _all_ tests if we don't have -# the modules below. Revisit this when not in a hurry. -# We only actually need the former two for the National Grid tests and the -# latter for the UTM tests. -eval { require Geo::Coordinates::OSGB; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::OSGB not installed"; -} - -eval { require Geo::Coordinates::ITM; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::ITM not installed"; -} - -eval { require Geo::Coordinates::UTM; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::UTM not installed"; -} - plan tests => 19; # Clear out the database from any previous runs. Modified: branches/rel_0_66/t/39_search_form.t =================================================================== --- branches/rel_0_66/t/39_search_form.t 2012-04-05 07:37:12 UTC (rev 1323) +++ branches/rel_0_66/t/39_search_form.t 2012-04-05 08:04:20 UTC (rev 1324) @@ -20,25 +20,6 @@ plan skip_all => "Test::HTML::Content not installed"; } -# Strictly speaking we don't need to skip _all_ tests if we don't have -# the modules below. Revisit this when not in a hurry. -# We only actually need the former two for the National Grid tests and the -# latter for the UTM tests. -eval { require Geo::Coordinates::OSGB; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::OSGB not installed"; -} - -eval { require Geo::Coordinates::ITM; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::ITM not installed"; -} - -eval { require Geo::Coordinates::UTM; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::UTM not installed"; -} - plan tests => 27; # Clear out the database from any previous runs. Modified: branches/rel_0_66/t/62_bug_trailing_whitespace.t =================================================================== --- branches/rel_0_66/t/62_bug_trailing_whitespace.t 2012-04-05 07:37:12 UTC (rev 1323) +++ branches/rel_0_66/t/62_bug_trailing_whitespace.t 2012-04-05 08:04:20 UTC (rev 1324) @@ -21,10 +21,6 @@ my $config = OpenGuides::Test->make_basic_config; my $guide = OpenGuides->new( config => $config ); -SKIP: { - eval { require Geo::Coordinates::OSGB; }; - skip "Geo::Coordinates::OSGB not installed", 2 if $@; - my $q = CGI->new( "" ); $q->param( -name => "os_x", -value => " 123456 " ); $q->param( -name => "os_y", -value => " 654321 " ); @@ -40,12 +36,9 @@ is( $metadata_vars{os_x}, "123456", "leading and trailing spaces stripped from os_x when processed" ); is( $metadata_vars{os_y}, "654321", "...and os_y" ); -} -SKIP: { - eval { require Geo::Coordinates::ITM; }; - skip "Geo::Coordinates::ITM not installed", 2 if $@; + $config->geo_handler( 2 ); my $q = CGI->new( "" ); $q->param( -name => "osie_x", -value => " 100000 " ); @@ -62,12 +55,7 @@ is( $metadata_vars{osie_x}, "100000", "leading and trailing spaces stripped from osie_x when processed" ); is( $metadata_vars{osie_y}, "200000", "...and osie_y" ); -} -SKIP: { - eval { require Geo::Coordinates::UTM; }; - skip "Geo::Coordinates::UTM not installed", 2 if $@; - $config->geo_handler( 3 ); my $q = CGI->new( "" ); $q->param( -name => "latitude", -value => " 1.463113 " ); @@ -84,7 +72,6 @@ is( $metadata_vars{latitude}, "1.463113", "leading and trailing spaces stripped from latitude when processed" ); is( $metadata_vars{longitude}, "-0.215293", "...and longitude" ); -} OpenGuides::Test->write_data( guide => $guide, Modified: branches/rel_0_66/t/66_bug_latlong_representation.t =================================================================== --- branches/rel_0_66/t/66_bug_latlong_representation.t 2012-04-05 07:37:12 UTC (rev 1323) +++ branches/rel_0_66/t/66_bug_latlong_representation.t 2012-04-05 08:04:20 UTC (rev 1324) @@ -13,10 +13,6 @@ plan skip_all => "DBD::SQLite could not be used - no database to test with ($error)"; } -eval { require Geo::Coordinates::UTM; }; -if ( $@ ) { - plan skip_all => "Geo::Coordinates::UTM not installed"; -} plan tests => 4; Modified: branches/rel_0_66/t/69_bug_zero_geo.t =================================================================== --- branches/rel_0_66/t/69_bug_zero_geo.t 2012-04-05 07:37:12 UTC (rev 1323) +++ branches/rel_0_66/t/69_bug_zero_geo.t 2012-04-05 08:04:20 UTC (rev 1324) @@ -50,9 +50,7 @@ is( @{$details{metadata}->{os_x}}[0], 0, "Zero os_x saved" ); is( @{$details{metadata}->{os_y}}[0], 0, "Zero os_y saved" ); -SKIP: { - eval { require Geo::Coordinates::ITM; }; - skip "Geo::Coordinates::ITM is not installed", 2 if $@; + $config->{geo_handler} = 2; Wiki::Toolkit::Setup::SQLite::cleardb( { dbname => "t/node.db" } ); @@ -76,7 +74,6 @@ is( @{$details{metadata}->{osie_x}}[0], 0, "Zero osie_x saved" ); is( @{$details{metadata}->{osie_y}}[0], 0, "Zero osie_y saved" ); -} $config->{geo_handler} = 3; Wiki::Toolkit::Setup::SQLite::cleardb( { dbname => "t/node.db" } );

1 0

r1323 - branches/rel_0_66
by svnadmin＠urchin.earth.li 05 Apr '12

05 Apr '12

Author: bob Date: 2012-04-05 08:37:12 +0100 (Thu, 05 Apr 2012) New Revision: 1323 Modified: branches/rel_0_66/Build.PL Log: require all 3 Geo modules we need. Modified: branches/rel_0_66/Build.PL =================================================================== --- branches/rel_0_66/Build.PL 2012-04-03 13:49:39 UTC (rev 1322) +++ branches/rel_0_66/Build.PL 2012-04-05 07:37:12 UTC (rev 1323) @@ -297,7 +297,6 @@ $drivers{$dbtype} => 0, 'File::Spec::Functions' => 0, 'File::Temp' => 0, - 'Geo::Coordinates::UTM' => 0, 'HTML::Entities' => 0, 'LWP::Simple' => 0, 'MIME::Lite' => 0, @@ -311,7 +310,9 @@ 'Data::Validate::URI' => 0, 'Net::Netmask' => 0, 'List::Util' => 0, + 'Geo::Coordinates::UTM' => 0, 'Geo::Coordinates::OSGB' => 0, + 'Geo::Coordinates::ITM' => 0, }, build_requires => { 'Module::Build' => '0.26', # API change for accessing config data

1 0

r1322 - branches/rel_0_66/t
by svnadmin＠urchin.earth.li 03 Apr '12

03 Apr '12

Author: bob Date: 2012-04-03 14:49:39 +0100 (Tue, 03 Apr 2012) New Revision: 1322 Modified: branches/rel_0_66/t/69_bug_zero_geo.t Log: Geo::Coordinates::ITM is not installed by default so skip tests. Modified: branches/rel_0_66/t/69_bug_zero_geo.t =================================================================== --- branches/rel_0_66/t/69_bug_zero_geo.t 2012-04-03 13:48:52 UTC (rev 1321) +++ branches/rel_0_66/t/69_bug_zero_geo.t 2012-04-03 13:49:39 UTC (rev 1322) @@ -50,7 +50,9 @@ is( @{$details{metadata}->{os_x}}[0], 0, "Zero os_x saved" ); is( @{$details{metadata}->{os_y}}[0], 0, "Zero os_y saved" ); - +SKIP: { + eval { require Geo::Coordinates::ITM; }; + skip "Geo::Coordinates::ITM is not installed", 2 if $@; $config->{geo_handler} = 2; Wiki::Toolkit::Setup::SQLite::cleardb( { dbname => "t/node.db" } ); @@ -74,7 +76,7 @@ is( @{$details{metadata}->{osie_x}}[0], 0, "Zero osie_x saved" ); is( @{$details{metadata}->{osie_y}}[0], 0, "Zero osie_y saved" ); - +} $config->{geo_handler} = 3; Wiki::Toolkit::Setup::SQLite::cleardb( { dbname => "t/node.db" } );

1 0

r1321 - branches/rel_0_66
by svnadmin＠urchin.earth.li 03 Apr '12

03 Apr '12

Author: bob Date: 2012-04-03 14:48:52 +0100 (Tue, 03 Apr 2012) New Revision: 1321 Modified: branches/rel_0_66/Build.PL Log: Lots of tests fail if we dont have Geo::Coordinates::OSGB. So adding as an explicit dependency. Modified: branches/rel_0_66/Build.PL =================================================================== --- branches/rel_0_66/Build.PL 2012-04-02 22:52:08 UTC (rev 1320) +++ branches/rel_0_66/Build.PL 2012-04-03 13:48:52 UTC (rev 1321) @@ -297,7 +297,7 @@ $drivers{$dbtype} => 0, 'File::Spec::Functions' => 0, 'File::Temp' => 0, - 'Geo::Coordinates::UTM' => 0, + 'Geo::Coordinates::UTM' => 0, 'HTML::Entities' => 0, 'LWP::Simple' => 0, 'MIME::Lite' => 0, @@ -311,6 +311,7 @@ 'Data::Validate::URI' => 0, 'Net::Netmask' => 0, 'List::Util' => 0, + 'Geo::Coordinates::OSGB' => 0, }, build_requires => { 'Module::Build' => '0.26', # API change for accessing config data

1 0

r1320 - in branches/rel_0_66: . lib lib/OpenGuides
by svnadmin＠urchin.earth.li 02 Apr '12

02 Apr '12

Author: bob Date: 2012-04-02 23:52:08 +0100 (Mon, 02 Apr 2012) New Revision: 1320 Modified: branches/rel_0_66/lib/OpenGuides.pm branches/rel_0_66/lib/OpenGuides/CGI.pm branches/rel_0_66/lib/OpenGuides/Search.pm branches/rel_0_66/lib/OpenGuides/Template.pm branches/rel_0_66/wiki.cgi Log: version bumps and copyright changes for a new release. Modified: branches/rel_0_66/lib/OpenGuides/CGI.pm =================================================================== --- branches/rel_0_66/lib/OpenGuides/CGI.pm 2012-04-02 22:28:32 UTC (rev 1319) +++ branches/rel_0_66/lib/OpenGuides/CGI.pm 2012-04-02 22:52:08 UTC (rev 1320) @@ -1,7 +1,7 @@ package OpenGuides::CGI; use strict; use vars qw( $VERSION ); -$VERSION = '0.09'; +$VERSION = '0.10'; use Carp qw( croak ); use CGI::Cookie; @@ -443,7 +443,7 @@ =head1 COPYRIGHT - Copyright (C) 2003-2008 The OpenGuides Project. All Rights Reserved. + Copyright (C) 2003-2012 The OpenGuides Project. All Rights Reserved. This module is free software; you can redistribute it and/or modify it under the same terms as Perl itself. Modified: branches/rel_0_66/lib/OpenGuides/Search.pm =================================================================== --- branches/rel_0_66/lib/OpenGuides/Search.pm 2012-04-02 22:28:32 UTC (rev 1319) +++ branches/rel_0_66/lib/OpenGuides/Search.pm 2012-04-02 22:52:08 UTC (rev 1320) @@ -1,6 +1,6 @@ package OpenGuides::Search; use strict; -our $VERSION = '0.13'; +our $VERSION = '0.14'; use CGI qw( :standard ); use Wiki::Toolkit::Plugin::Locator::Grid; @@ -827,7 +827,7 @@ =head1 COPYRIGHT - Copyright (C) 2003-2008 The OpenGuides Project. All Rights Reserved. + Copyright (C) 2003-2012 The OpenGuides Project. All Rights Reserved. The OpenGuides distribution is free software; you can redistribute it and/or modify it under the same terms as Perl itself. Modified: branches/rel_0_66/lib/OpenGuides/Template.pm =================================================================== --- branches/rel_0_66/lib/OpenGuides/Template.pm 2012-04-02 22:28:32 UTC (rev 1319) +++ branches/rel_0_66/lib/OpenGuides/Template.pm 2012-04-02 22:52:08 UTC (rev 1320) @@ -2,7 +2,7 @@ use strict; use vars qw( $VERSION ); -$VERSION = '0.15'; +$VERSION = '0.16'; use Carp qw( croak ); use CGI; # want to get rid of this and put the burden on the templates @@ -649,7 +649,7 @@ =head1 COPYRIGHT - Copyright (C) 2003-2009 The OpenGuides Project. All Rights Reserved. + Copyright (C) 2003-2012 The OpenGuides Project. All Rights Reserved. This module is free software; you can redistribute it and/or modify it under the same terms as Perl itself. Modified: branches/rel_0_66/lib/OpenGuides.pm =================================================================== --- branches/rel_0_66/lib/OpenGuides.pm 2012-04-02 22:28:32 UTC (rev 1319) +++ branches/rel_0_66/lib/OpenGuides.pm 2012-04-02 22:52:08 UTC (rev 1320) @@ -14,7 +14,7 @@ use vars qw( $VERSION ); -$VERSION = '0.65'; +$VERSION = '0.66'; =head1 NAME @@ -2338,7 +2338,7 @@ =head1 COPYRIGHT - Copyright (C) 2003-2010 The OpenGuides Project. All Rights Reserved. + Copyright (C) 2003-2012 The OpenGuides Project. All Rights Reserved. The OpenGuides distribution is free software; you can redistribute it and/or modify it under the same terms as Perl itself. Modified: branches/rel_0_66/wiki.cgi =================================================================== --- branches/rel_0_66/wiki.cgi 2012-04-02 22:28:32 UTC (rev 1319) +++ branches/rel_0_66/wiki.cgi 2012-04-02 22:52:08 UTC (rev 1320) @@ -4,7 +4,7 @@ use warnings; use sigtrap die => 'normal-signals'; use vars qw( $VERSION ); -$VERSION = '0.65'; +$VERSION = '0.66'; use CGI qw/:standard/; use CGI::Carp qw(croak);

1 0

r1319 - branches
by svnadmin＠urchin.earth.li 02 Apr '12

02 Apr '12

Author: bob Date: 2012-04-02 23:28:32 +0100 (Mon, 02 Apr 2012) New Revision: 1319 Added: branches/rel_0_66/ Log: release branch for 0.66

1 0

r1318 - trunk
by svnadmin＠urchin.earth.li 02 Apr '12

02 Apr '12

Author: kake Date: 2012-04-02 20:13:20 +0100 (Mon, 02 Apr 2012) New Revision: 1318 Modified: trunk/Changes Log: Added documentation of my previous commit to the Changes file. Modified: trunk/Changes =================================================================== --- trunk/Changes 2012-04-02 08:35:16 UTC (rev 1317) +++ trunk/Changes 2012-04-02 19:13:20 UTC (rev 1318) @@ -16,6 +16,7 @@ and locales, to avoid creating undeletable pages. Add an autocreate_content.tt template to include a map link in content for autocreated categories and locales (#275). + Make sure the show_missing_metadata action skips redirects. 0.65 28 February 2010 Fix some more broken POD and add POD unit test (#268)

1 0

r1317 - in trunk: lib t
by svnadmin＠urchin.earth.li 02 Apr '12

02 Apr '12

Author: kake Date: 2012-04-02 09:35:16 +0100 (Mon, 02 Apr 2012) New Revision: 1317 Modified: trunk/lib/OpenGuides.pm trunk/t/71_missing_metadata.t Log: Fixed bug where missing metadata search was picking up redirect pages. Modified: trunk/lib/OpenGuides.pm =================================================================== --- trunk/lib/OpenGuides.pm 2012-03-20 12:16:15 UTC (rev 1316) +++ trunk/lib/OpenGuides.pm 2012-04-02 08:35:16 UTC (rev 1317) @@ -2009,8 +2009,8 @@ =item B<show_missing_metadata> -Search for nodes which don't have a certain kind of metadata. Optionally -also excludes Locales and Categories +Search for nodes which don't have a certain kind of metadata. Excludes nodes +which are pure redirects, and optionally also excludes locales and categories. =cut @@ -2032,22 +2032,19 @@ # Only search if they supplied at least a metadata type if($metadata_type) { $done_search = 1; - @nodes = $wiki->list_nodes_by_missing_metadata( + my @all_nodes = $wiki->list_nodes_by_missing_metadata( metadata_type => $metadata_type, metadata_value => $metadata_value, ignore_case => 1, ); - # Do we need to filter some nodes out? - if($exclude_locales || $exclude_categories) { - my @all_nodes = @nodes; - @nodes = (); - - foreach my $node (@all_nodes) { - if($exclude_locales && $node =~ /^Locale /) { next; } - if($exclude_categories && $node =~ /^Category /) { next; } - push @nodes, $node; - } + # Filter out redirects; also filter out locales/categories if required. + foreach my $node ( @all_nodes ) { + next if ( $exclude_locales && $node =~ /^Locale / ); + next if ( $exclude_categories && $node =~ /^Category / ); + my $content = $wiki->retrieve_node( $node ); + next if OpenGuides::Utils->detect_redirect( content => $content ); + push @nodes, $node; } } Modified: trunk/t/71_missing_metadata.t =================================================================== --- trunk/t/71_missing_metadata.t 2012-03-20 12:16:15 UTC (rev 1316) +++ trunk/t/71_missing_metadata.t 2012-04-02 08:35:16 UTC (rev 1317) @@ -24,7 +24,9 @@ -# Add 3 different pages, one of which with two versions +# Add four different pages, one of which with two versions, one of which +# a redirect. The redirect should not show up on any "missing metadata" +# searches, regardless of the condition of the page it points to. $wiki->write_node( "Test Page", "foo", undef, { category => "Alpha", lat=>"" } ) or die "Couldn't write node"; @@ -44,8 +46,13 @@ $wiki->write_node( "Locale Bar", "foo version 2", $data{checksum}, { category => "Locales", lat=>"8.88" } ) or die "Couldn't write locale for the 2nd time"; +OpenGuides::Test->write_data( + guide => $guide, + node => "Redirect Test", + content => "#REDIRECT [[Test Page]]", + return_output => 1, + ); - # Try without search parameters my %ttvars = eval { $guide->show_missing_metadata( return_tt_vars=> 1 ); @@ -112,7 +119,7 @@ my $output = eval { $guide->show_missing_metadata( return_output=>1 ); }; -is( $@, "", "->how_missing_metadata doesn't die" ); +is( $@, "", "->show_missing_metadata doesn't die" ); like( $output, qr|Missing Metadata|, "Right page" ); like( $output, qr|Metadata Type|, "Has prompts" ); @@ -121,6 +128,6 @@ $output = eval { $guide->show_missing_metadata( return_output=>1, metadata_type=>'lat' ); }; -is( $@, "", "->how_missing_metadata doesn't die" ); +is( $@, "", "->show_missing_metadata doesn't die" ); like( $output, qr|<h3>Pages</h3>|, "searched" ); like( $output, qr|Test Page|, "had node" );

1 0

r1316 - trunk/t
by svnadmin＠urchin.earth.li 20 Mar '12

20 Mar '12

Author: kake Date: 2012-03-20 12:16:15 +0000 (Tue, 20 Mar 2012) New Revision: 1316 Modified: trunk/t/34_search_paging.t Log: Skip the right number of tests. Modified: trunk/t/34_search_paging.t =================================================================== --- trunk/t/34_search_paging.t 2012-03-18 09:48:44 UTC (rev 1315) +++ trunk/t/34_search_paging.t 2012-03-20 12:16:15 UTC (rev 1316) @@ -30,7 +30,7 @@ # Test with OS co-ords. eval { require Geo::Coordinates::OSGB; }; SKIP: { - skip "Geo::Coordinates::OSGB not installed", 3 if $@; + skip "Geo::Coordinates::OSGB not installed", 6 if $@; $config->geo_handler( 1 ); foreach my $i ( 1 .. 50 ) { @@ -69,7 +69,7 @@ # Test with OSIE co-ords. eval { require Geo::Coordinates::ITM; }; SKIP: { - skip "Geo::Coordinates::ITM not installed", 3 if $@; + skip "Geo::Coordinates::ITM not installed", 6 if $@; # We must create a new search object after changing the geo_handler # in order to force it to create a fresh locator. @@ -111,7 +111,7 @@ # Test with UTM. eval { require Geo::Coordinates::UTM; }; SKIP: { - skip "Geo::Coordinates::UTM not installed", 3 if $@; + skip "Geo::Coordinates::UTM not installed", 6 if $@; # We must create a new search object after changing the geo_handler # in order to force it to create a fresh locator.

1 0

r1315 - in trunk: . lib/OpenGuides t
by svnadmin＠urchin.earth.li 18 Mar '12

18 Mar '12

Author: kake Date: 2012-03-18 09:48:44 +0000 (Sun, 18 Mar 2012) New Revision: 1315 Added: trunk/t/92_node_name_from_cgi_obj.t trunk/t/93_redirect_without_spaces.t Modified: trunk/Changes trunk/MANIFEST trunk/lib/OpenGuides/CGI.pm trunk/wiki.cgi Log: Added code to deal with node name parameters in URLs having spaces instead of underscores, to take account of people typing manually (#114). Modified: trunk/Changes =================================================================== --- trunk/Changes 2012-03-16 16:08:13 UTC (rev 1314) +++ trunk/Changes 2012-03-18 09:48:44 UTC (rev 1315) @@ -5,6 +5,9 @@ 0.66 ? All templates now have access to the "username" TT variable. + Node name parameters in URLs are now accepted with spaces instead of + underscores, to take account of people typing manually - these will + redirect (303) to the proper URLs with underscores (#114). Add CSS classes for each category and locale to the "content" div (and hence we now require version 2.24 of Template). Switch to using Geo::Coordinates::OSGB/ITM instead of Modified: trunk/MANIFEST =================================================================== --- trunk/MANIFEST 2012-03-16 16:08:13 UTC (rev 1314) +++ trunk/MANIFEST 2012-03-18 09:48:44 UTC (rev 1315) @@ -156,6 +156,8 @@ t/86_recent_changes.t t/90_css_category_locale_classes.t t/91_username_in_templates.t +t/92_node_name_from_cgi_obj.t +t/93_redirect_without_spaces.t t/templates/15_test.tt wiki.cgi META.json Modified: trunk/lib/OpenGuides/CGI.pm =================================================================== --- trunk/lib/OpenGuides/CGI.pm 2012-03-16 16:08:13 UTC (rev 1314) +++ trunk/lib/OpenGuides/CGI.pm 2012-03-18 09:48:44 UTC (rev 1315) @@ -71,6 +71,142 @@ =over 4 +=item B<extract_node_param> + + my $config_file = $ENV{OPENGUIDES_CONFIG_FILE} || "wiki.conf"; + my $config = OpenGuides::Config->new( file => $config_file ); + my $guide = OpenGuides->new( config => $config ); + my $wiki = $guide->wiki; + + my $q = CGI->new; + + my $node_param = OpenGuides::CGI->extract_node_param( + wiki => $wiki, cgi_obj => $q ); + +Returns the title, id, or keywords parameter from the URL. Normally +this will be something like "British_Museum", i.e. with underscores +instead of spaces. However if the URL does contain spaces (encoded as +%20 or +), the return value will be e.g. "British Museum" instead. + +Croaks unless a L<Wiki::Toolkit> object is supplied as C<wiki> and a +L<CGI> object is supplied as C<cgi_obj>. + +=cut + +sub extract_node_param { + my ($class, %args) = @_; + my $wiki = $args{wiki} or croak "No wiki supplied"; + croak "wiki not a Wiki::Toolkit object" + unless UNIVERSAL::isa( $wiki, "Wiki::Toolkit" ); + my $q = $args{cgi_obj} or croak "No cgi_obj supplied"; + croak "cgi_obj not a CGI object" + unless UNIVERSAL::isa( $q, "CGI" ); + + # Note $q->param( "keywords" ) gives you the entire param string. + # We need this to do URLs like foo.com/wiki.cgi?This_Page + my $param = $q->param( "id" ) + || $q->param( "title" ) + || join( " ", $q->param( "keywords" ) ) + || ""; + $param =~ s/%20/ /g; + $param =~ s/\+/ /g; + return $param; +} + +=item B<extract_node_name> + + my $config_file = $ENV{OPENGUIDES_CONFIG_FILE} || "wiki.conf"; + my $config = OpenGuides::Config->new( file => $config_file ); + my $guide = OpenGuides->new( config => $config ); + my $wiki = $guide->wiki; + + my $q = CGI->new; + + my $node_name = OpenGuides::CGI->extract_node_name( + wiki => $wiki, cgi_obj => $q ); + +Returns the name of the node the user wishes to display/manipulate, as +we expect it to be stored in the database. Normally this will be +something like "British Museum", i.e. with spaces in. Croaks unless a +L<Wiki::Toolkit> object is supplied as C<wiki> and a L<CGI> object is +supplied as C<cgi_obj>. + +=cut + +sub extract_node_name { + my ($class, %args) = @_; + # The next call will validate our args for us and croak if necessary. + my $param = $class->extract_node_param( %args ); + + # Sometimes people type spaces instead of underscores. + $param =~ s/ /_/g; + $param =~ s/%20/_/g; + $param =~ s/\+/_/g; + + my $formatter = $args{wiki}->formatter; + return $formatter->node_param_to_node_name( $param ); +} + +=item B<check_spaces_redirect> + + my $config_file = $ENV{OPENGUIDES_CONFIG_FILE} || "wiki.conf"; + my $config = OpenGuides::Config->new( file => $config_file ); + my $guide = OpenGuides->new( config => $config ); + + my $q = CGI->new; + + my $url = OpenGuides::CGI->check_spaces_redirect( + wiki => $wiki, cgi_obj => $q ); + +If the user seems to have typed a URL with spaces in the node param +instead of underscores, this method will return the URL with the +underscores put in. Otherwise, it returns false. + +=cut + +sub check_spaces_redirect { + my ($class, %args) = @_; + my $wiki = $args{wiki}; + my $q = $args{cgi_obj}; + + my $name = $class->extract_node_name( wiki => $wiki, cgi_obj => $q ); + my $param = $class->extract_node_param( wiki => $wiki, cgi_obj => $q ); + + # If we can't figure out the name or param, it's safest to do nothing. + if ( !$name || !$param ) { + return 0; + } + + # If the name has no spaces in, or the name and param differ, we're + # probably OK. + if ( ( $name !~ / / ) || ( $name ne $param ) ) { + return 0; + } + + # Make a new CGI object to manipulate, to avoid action-at-a-distance. + my $new_q = CGI->new( $q ); + my $formatter = $wiki->formatter; + my $real_param = $formatter->node_name_to_node_param( $name ); + + if ( $q->param( "id" ) ) { + $new_q->param( -name => "id", -value => $real_param ); + } elsif ( $q->param( "title" ) ) { + $new_q->param( -name => "title", -value => $real_param ); + } else { + # OK, we have the keywords case; the entire param string is the + # node param. So just delete all existing parameters and stick + # the node param back in. + $new_q->delete_all(); + $new_q->param( -name => "id", -value => $real_param ); + } + + my $url = $new_q->self_url; + + # Escaped commas are ugly. + $url =~ s/%2C/,/g; + return $url; +} + =item B<make_prefs_cookie> my $cookie = OpenGuides::CGI->make_prefs_cookie( Added: trunk/t/92_node_name_from_cgi_obj.t =================================================================== --- trunk/t/92_node_name_from_cgi_obj.t (rev 0) +++ trunk/t/92_node_name_from_cgi_obj.t 2012-03-18 09:48:44 UTC (rev 1315) @@ -0,0 +1,101 @@ +use strict; +use OpenGuides; +use OpenGuides::CGI; +use OpenGuides::Test; +use Test::More; + +eval { require DBD::SQLite; }; +if ( $@ ) { + my ($error) = $@ =~ /^(.*?)\n/; + plan skip_all => + "DBD::SQLite could not be used - no database to test with. ($error)"; +} + +plan tests => 18; + +my $config = OpenGuides::Test->make_basic_config; +my $guide = OpenGuides->new( config => $config ); +my $wiki = $guide->wiki; + +# Clear out the database from any previous runs. +OpenGuides::Test::refresh_db(); + +# Write a node. +OpenGuides::Test->write_data( + guide => $guide, + node => "Ship Of Fools", + return_output => 1, + ); + +my ( $q, $node, $param ); + +# Test we get the right name/param with various CGI objects. Make sure to +# always start with an empty one by passing the empty string as arg. + +$q = CGI->new( "" ); +$q->param( -name => "id", -value => "Ship_Of_Fools" ); +$node = OpenGuides::CGI->extract_node_name( cgi_obj => $q, wiki => $wiki ); +is( $node, "Ship Of Fools", + "extract_node_name gives correct name with id param" ); +$param = OpenGuides::CGI->extract_node_param( cgi_obj => $q, wiki => $wiki ); +is( $param, "Ship_Of_Fools", "...as does extract_node_param" ); + +$q = CGI->new( "" ); +$q->param( -name => "title", -value => "Ship_Of_Fools" ); +$node = OpenGuides::CGI->extract_node_name( cgi_obj => $q, wiki => $wiki ); +is( $node, "Ship Of Fools", "title param works for node name" ); +$param = OpenGuides::CGI->extract_node_param( cgi_obj => $q, wiki => $wiki ); +is( $param, "Ship_Of_Fools", "...and for node param" ); + +$q = CGI->new( "Ship_Of_Fools" ); +$node = OpenGuides::CGI->extract_node_name( cgi_obj => $q, wiki => $wiki ); +is( $node, "Ship Of Fools", "whole-string node param works for node name" ); +$param = OpenGuides::CGI->extract_node_param( cgi_obj => $q, wiki => $wiki ); +is( $param, "Ship_Of_Fools", "...and for node param" ); + +# Now try it with encoded spaces instead of underscores. +$q = CGI->new( "" ); +$q->param( -name => "id", -value => "Ship%20Of%20Fools" ); +$node = OpenGuides::CGI->extract_node_name( cgi_obj => $q, wiki => $wiki ); +is( $node, "Ship Of Fools", + "id param works for node name with encoded spaces" ); +$param = OpenGuides::CGI->extract_node_param( cgi_obj => $q, wiki => $wiki ); +is( $param, "Ship Of Fools", "...as does node param" ); + +$q = CGI->new( "" ); +$q->param( -name => "title", -value => "Ship%20Of%20Fools" ); +$node = OpenGuides::CGI->extract_node_name( cgi_obj => $q, wiki => $wiki ); +is( $node, "Ship Of Fools", + "title param works for node name with encoded spaces" ); +$param = OpenGuides::CGI->extract_node_param( cgi_obj => $q, wiki => $wiki ); +is( $param, "Ship Of Fools", "...as does node param" ); + +$q = CGI->new( "Ship%20Of%20Fools" ); +$node = OpenGuides::CGI->extract_node_name( cgi_obj => $q, wiki => $wiki ); +is( $node, "Ship Of Fools", + "whole-string node param works for node name with encoded spaces" ); +$param = OpenGuides::CGI->extract_node_param( cgi_obj => $q, wiki => $wiki ); +is( $param, "Ship Of Fools", "...as does node param" ); + +# Finally try it with plus signs. +$q = CGI->new( "" ); +$q->param( -name => "id", -value => "Ship+Of+Fools" ); +$node = OpenGuides::CGI->extract_node_name( cgi_obj => $q, wiki => $wiki ); +is( $node, "Ship Of Fools", "id param works for node name with plus signs" ); +$param = OpenGuides::CGI->extract_node_param( cgi_obj => $q, wiki => $wiki ); +is( $param, "Ship Of Fools", "...as does node param" ); + +$q = CGI->new( "" ); +$q->param( -name => "title", -value => "Ship+Of+Fools" ); +$node = OpenGuides::CGI->extract_node_name( cgi_obj => $q, wiki => $wiki ); +is( $node, "Ship Of Fools", + "title param works for node name with plus signs" ); +$param = OpenGuides::CGI->extract_node_param( cgi_obj => $q, wiki => $wiki ); +is( $param, "Ship Of Fools", "...as does node param" ); + +$q = CGI->new( "Ship+Of+Fools" ); +$node = OpenGuides::CGI->extract_node_name( cgi_obj => $q, wiki => $wiki ); +is( $node, "Ship Of Fools", + "whole-string node param works for node name with plus signs" ); +$param = OpenGuides::CGI->extract_node_param( cgi_obj => $q, wiki => $wiki ); +is( $param, "Ship Of Fools", "...as does node param" ); Added: trunk/t/93_redirect_without_spaces.t =================================================================== --- trunk/t/93_redirect_without_spaces.t (rev 0) +++ trunk/t/93_redirect_without_spaces.t 2012-03-18 09:48:44 UTC (rev 1315) @@ -0,0 +1,139 @@ +use strict; +use OpenGuides; +use OpenGuides::CGI; +use OpenGuides::Test; +use Test::More; + +eval { require DBD::SQLite; }; +if ( $@ ) { + my ($error) = $@ =~ /^(.*?)\n/; + plan skip_all => + "DBD::SQLite could not be used - no database to test with. ($error)"; +} + +plan tests => 27; + +my $config = OpenGuides::Test->make_basic_config; +my $guide = OpenGuides->new( config => $config ); +my $wiki = $guide->wiki; + +# Clear out the database from any previous runs. +OpenGuides::Test::refresh_db(); + +# Write a couple of nodes, one with a single-word name, one with multiple. +OpenGuides::Test->write_data( + guide => $guide, + node => "Croydon", + return_output => 1, + ); +OpenGuides::Test->write_data( + guide => $guide, + node => "Ship Of Fools", + return_output => 1, + ); + +my ( $q, $url ); + +# Check we don't get redirects with the single-word node. + +$q = CGI->new( "" ); +$q->param( -name => "id", -value => "Croydon" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( !$url, "No URL redirect for id param with single-word node" ); + +$q = CGI->new( "" ); +$q->param( -name => "title", -value => "Croydon" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( !$url, "...nor for title param" ); + +$q = CGI->new( "Croydon" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( !$url, "...nor for whole-string param" ); + +# Nor with the "proper" URLs with underscores. + +$q = CGI->new( "" ); +$q->param( -name => "id", -value => "Ship_Of_Fools" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( !$url, "No URL redirect for id param with underscores" ); + +$q = CGI->new( "" ); +$q->param( -name => "title", -value => "Ship_Of_Fools" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( !$url, "...nor for title param with underscores" ); + +$q = CGI->new( "Ship_Of_Fools" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( !$url, "...nor for whole-string node param with underscores" ); + +# Now check that we get redirects when supplying CGI objects with spaces +# in the node parameter. + +# First encoded spaces. + +$q = CGI->new( "" ); +$q->param( -name => "id", -value => "Ship%20Of%20Fools" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( $url, "We do get a redirect for id param with encoded spaces" ); +is( $url, "http://localhost?id=Ship_Of_Fools", "...the right one" ); +$q->param( -name => "action", -value => "edit" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( $url, "...also get redirect with edit param" ); +is( $url, "http://localhost?id=Ship_Of_Fools;action=edit", + "...the right one" ); + +$q = CGI->new( "" ); +$q->param( -name => "title", -value => "Ship%20Of%20Fools" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( $url, "...also get redirect for title param with encoded spaces" ); +is( $url, "http://localhost?title=Ship_Of_Fools", "...the right one" ); +$q->param( -name => "action", -value => "edit" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( $url, "...also get redirect with edit param" ); +is( $url, "http://localhost?title=Ship_Of_Fools;action=edit", + "...the right one" ); + +$q = CGI->new( "Ship%20Of%20Fools" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( $url, + "...also get redirect for whole-string node param with encoded spaces" ); +is( $url, "http://localhost?id=Ship_Of_Fools", "...the right one" ); + +# Try it with plus signs. + +$q = CGI->new( "" ); +$q->param( -name => "id", -value => "Ship+Of+Fools" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( $url, "We do get a redirect for id param with plus signs" ); +is( $url, "http://localhost?id=Ship_Of_Fools", "...the right one" ); +$q->param( -name => "action", -value => "edit" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( $url, "...also get redirect with edit param" ); +is( $url, "http://localhost?id=Ship_Of_Fools;action=edit", + "...the right one" ); + +$q = CGI->new( "" ); +$q->param( -name => "title", -value => "Ship+Of+Fools" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( $url, "...and for title param with plus signs" ); +is( $url, "http://localhost?title=Ship_Of_Fools", "...the right one" ); +$q->param( -name => "action", -value => "edit" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( $url, "...also get redirect with edit param" ); +is( $url, "http://localhost?title=Ship_Of_Fools;action=edit", + "...the right one" ); + +$q = CGI->new( "Ship+Of+Fools" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +ok( $url, "...and for whole-string node param with plus signs" ); +is( $url, "http://localhost?id=Ship_Of_Fools", "...the right one" ); + +# Make sure commas don't get escaped, for it is unnecessary and ugly. +OpenGuides::Test->write_data( + guide => $guide, + node => "Londis, Pitlake", + return_output => 1, + ); +$q = CGI->new( "Londis, Pitlake" ); +$url = OpenGuides::CGI->check_spaces_redirect( cgi_obj => $q, wiki => $wiki ); +is( $url, "http://localhost?id=Londis,_Pitlake", "Commas don't get escaped." ); Modified: trunk/wiki.cgi =================================================================== --- trunk/wiki.cgi 2012-03-16 16:08:13 UTC (rev 1314) +++ trunk/wiki.cgi 2012-03-18 09:48:44 UTC (rev 1315) @@ -30,15 +30,21 @@ $guide = OpenGuides->new( config => $config ); $wiki = $guide->wiki; $formatter = $wiki->formatter; - - # Get CGI object, find out what to do. $q = CGI->new; - # Note $q->param('keywords') gives you the entire param string. - # We need this to do URLs like foo.com/wiki.cgi?This_Page - my $node = $q->param('id') || $q->param('title') || $q->param('keywords') || ''; - $node = $formatter->node_param_to_node_name( $node ); + # See if we need to redirect due to spaces in URL. + my $redirect = OpenGuides::CGI->check_spaces_redirect( + cgi_obj => $q, wiki => $wiki ); + if ( $redirect ) { + print $q->redirect( -uri => $redirect, -status => 303 ); + exit 0; + } + + # No redirect - carry on. + my $node = OpenGuides::CGI->extract_node_name( + cgi_obj => $q, wiki => $wiki ); + # If we did a post, then CGI->param probably hasn't fully de-escaped, # in the same way as a get would've done my $request_method = $q->request_method() || '';

1 0

← Newer
1
...
34
35
36
37
38
39
40
...
88
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

openguides-commits