openguides-commits December 2012

openguides-commits@lists.openguides.org

1 participants
2 discussions

by svnadmin＠urchin.earth.li

Author: dom Date: 2012-12-18 22:27:01 +0000 (Tue, 18 Dec 2012) New Revision: 1448 Modified: trunk/Changes trunk/t/904_leaflet.t trunk/t/905_multiple_index.t Log: Work around a "No such method textContent" bug in Test::HTML::Content when XML::LibXML is not installed (and update previous Change entry) Modified: trunk/Changes =================================================================== --- trunk/Changes 2012-12-18 18:15:56 UTC (rev 1447) +++ trunk/Changes 2012-12-18 22:27:01 UTC (rev 1448) @@ -6,7 +6,10 @@ 0.71 ? Added scale to category/locale index maps. Fix several test failures triggered by the stricter - Test::HTML::Content (et al) found in current Debian unstable. + Test::HTML::Content (et al) mode used when XML::LibXML is + not installed + Work around a "No such method textContent" bug in + Test::HTML::Content when XML::LibXML is not installed 0.70 26 August 2012 New elements allowed in page content: span, dl, dt, dd (fixes #303). Modified: trunk/t/904_leaflet.t =================================================================== --- trunk/t/904_leaflet.t 2012-12-18 18:15:56 UTC (rev 1447) +++ trunk/t/904_leaflet.t 2012-12-18 22:27:01 UTC (rev 1448) @@ -182,7 +182,7 @@ return_output => 1 ); SKIP: { skip "Test::HTML::Content not available", 1 unless $thc; - Test::HTML::Content::title_ok( $output, qr/Map of all nodes/, + Test::HTML::Content::tag_ok( $output, 'title', {}, qr/Map of all nodes/, "<title> correct when showing map of everything" ); } like( $output, qr/<h2>Map\s+of\s+all\s+nodes/, "...as is <h2> title" ); Modified: trunk/t/905_multiple_index.t =================================================================== --- trunk/t/905_multiple_index.t 2012-12-18 18:15:56 UTC (rev 1447) +++ trunk/t/905_multiple_index.t 2012-12-18 22:27:01 UTC (rev 1448) @@ -56,7 +56,7 @@ "Right number of nodes returned in pure category search" ); my $output = $guide->show_index( cat => "pubs", return_output => 1, noheaders => 1 ); -Test::HTML::Content::title_ok( $output, "Index of Category Pubs - Test", +Test::HTML::Content::tag_ok( $output, 'title', {}, "Index of Category Pubs - Test", "...and page title is correct" ); Test::HTML::Content::link_ok( $output, $config->script_name . "?Category_Pubs", "...and we link to the category page." ); @@ -66,7 +66,7 @@ "Right number of nodes returned in pure locale search" ); $output = $guide->show_index( loc => "waddon", return_output => 1, noheaders => 1 ); -Test::HTML::Content::title_ok( $output, "Index of Locale Waddon - Test", +Test::HTML::Content::tag_ok( $output, 'title', {}, "Index of Locale Waddon - Test", "...and page title is correct" ); Test::HTML::Content::link_ok( $output, $config->script_name . "?Locale_Waddon", "...and we link to the locale page." ); @@ -77,7 +77,7 @@ "Right number of nodes returned in category+locale search" ); $output = $guide->show_index( cat => "pubs", loc => "waddon", return_output => 1, noheaders => 1 ); -Test::HTML::Content::title_ok( $output, +Test::HTML::Content::tag_ok( $output, 'title', {}, "Index of Category Pubs and Locale Waddon - Test", "...and page title is correct" ); Test::HTML::Content::link_ok( $output, $config->script_name . "?Category_Pubs", @@ -93,7 +93,7 @@ "Right number of nodes returned in category+locale search with map" ); $output = $guide->show_index( cat => "pubs", loc => "waddon", format => "map", return_output => 1, noheaders => 1 ); -Test::HTML::Content::title_ok( $output, +Test::HTML::Content::tag_ok( $output, 'title', {}, "Map of Category Pubs and Locale Waddon - Test", "...and page title is correct" ); Test::HTML::Content::link_ok( $output, $config->script_name . "?Category_Pubs",

10 years, 9 months

r1447 - in trunk: . t templates

by svnadmin＠urchin.earth.li

Author: dom Date: 2012-12-18 18:15:56 +0000 (Tue, 18 Dec 2012) New Revision: 1447 Modified: trunk/Changes trunk/t/701_missing_metadata.t trunk/t/906_show_index_form.t trunk/templates/header.tt trunk/templates/preferences.tt Log: Fix several test failures triggered by the stricter Test::HTML::Content (et al) found in current Debian unstable. Modified: trunk/Changes =================================================================== --- trunk/Changes 2012-09-01 09:31:03 UTC (rev 1446) +++ trunk/Changes 2012-12-18 18:15:56 UTC (rev 1447) @@ -5,6 +5,8 @@ 0.71 ? Added scale to category/locale index maps. + Fix several test failures triggered by the stricter + Test::HTML::Content (et al) found in current Debian unstable. 0.70 26 August 2012 New elements allowed in page content: span, dl, dt, dd (fixes #303). Modified: trunk/t/701_missing_metadata.t =================================================================== --- trunk/t/701_missing_metadata.t 2012-09-01 09:31:03 UTC (rev 1446) +++ trunk/t/701_missing_metadata.t 2012-12-18 18:15:56 UTC (rev 1447) @@ -122,7 +122,8 @@ # Test the normal, HTML version my $output = eval { - $guide->show_missing_metadata( return_output=>1 ); + $guide->show_missing_metadata( return_output=>1, + noheaders => 1); }; is( $@, "", "->show_missing_metadata doesn't die when called with no metadata_type" ); @@ -134,7 +135,8 @@ $output = eval { $guide->show_missing_metadata( return_output => 1, - metadata_type => "latitude" ); + metadata_type => "latitude", + noheaders => 1); }; is( $@, "", "->show_missing_metadata doesn't die when called with " . "metadata_type 'latitude'" ); Modified: trunk/t/906_show_index_form.t =================================================================== --- trunk/t/906_show_index_form.t 2012-09-01 09:31:03 UTC (rev 1446) +++ trunk/t/906_show_index_form.t 2012-12-18 18:15:56 UTC (rev 1447) @@ -35,7 +35,7 @@ OpenGuides::CGI->make_index_form_dropdowns( guide => $guide ); }; ok( !$@, "->make_index_form_dropdowns doesn't die when no criteria supplied" ); -my $html = join( " ", ( map { $_->{html} } @dropdowns ) ); +my $html = '<html>' . join( " ", ( map { $_->{html} } @dropdowns ) ) . '</html>'; Test::HTML::Content::tag_ok( $html, "select", { name => "cat" }, "...and we have a 'cat' select" ); like( $html, qr/apples.*bananas.*cherries/is, @@ -63,7 +63,7 @@ ); }; ok( !$@, "->make_index_form_dropdowns doesn't die when category supplied" ); -$html = join( " ", ( map { $_->{html} } @dropdowns ) ); +$html = '<html>' . join( " ", ( map { $_->{html} } @dropdowns ) ) . '</html>'; Test::HTML::Content::tag_ok( $html, "select", { name => "cat" }, "...and we have a 'cat' select" ); like( $html, qr/apples.*bananas.*cherries/is, @@ -97,7 +97,7 @@ ); }; ok( !$@, "->make_index_form_dropdowns doesn't die when locale supplied" ); -$html = join( " ", ( map { $_->{html} } @dropdowns ) ); +$html = '<html>' . join( " ", ( map { $_->{html} } @dropdowns ) ). '</html>'; Test::HTML::Content::tag_ok( $html, "select", { name => "cat" }, "...and we have a 'cat' select" ); like( $html, qr/apples.*bananas.*cherries/is, @@ -135,7 +135,7 @@ }; ok( !$@, "->make_index_form_dropdowns doesn't die when locale and categorysupplied" ); -$html = join( " ", ( map { $_->{html} } @dropdowns ) ); +$html = '<html>' . join( " ", ( map { $_->{html} } @dropdowns ) ). '</html>'; Test::HTML::Content::tag_ok( $html, "select", { name => "cat" }, "...and we have a 'cat' select" ); like( $html, qr/apples.*bananas.*cherries/is, Modified: trunk/templates/header.tt =================================================================== --- trunk/templates/header.tt 2012-09-01 09:31:03 UTC (rev 1446) +++ trunk/templates/header.tt 2012-12-18 18:15:56 UTC (rev 1447) @@ -71,7 +71,7 @@ [% END %] [% UNLESS not_editable %] <link rel="alternate" type="application/wiki" title="Edit this page!" - href="[% source_site or full_cgi_url %]?id=[% node_param %];action=edit"> + href="[% source_site or full_cgi_url %]?id=[% node_param %];action=edit" /> [% END %] [% IF display_google_maps %] Modified: trunk/templates/preferences.tt =================================================================== --- trunk/templates/preferences.tt 2012-09-01 09:31:03 UTC (rev 1446) +++ trunk/templates/preferences.tt 2012-12-18 18:15:56 UTC (rev 1447) @@ -14,7 +14,7 @@ <p> [% IF prefs.preview_above_edit_box %] - <input type="checkbox" id="preview_above" name="preview_above_edit_box" value="1" checked /> + <input type="checkbox" id="preview_above" name="preview_above_edit_box" value="1" checked="1" /> [% ELSE %] <input type="checkbox" id="preview_above" name="preview_above_edit_box" value="1" /> [% END %] @@ -23,7 +23,7 @@ <p> [% IF prefs.include_geocache_link %] - <input type="checkbox" id="geocache" name="include_geocache_link" value="1" checked /> + <input type="checkbox" id="geocache" name="include_geocache_link" value="1" checked="1" /> [% ELSE %] <input type="checkbox" id="geocache" name="include_geocache_link" value="1" /> [% END %] @@ -32,7 +32,7 @@ <p> [% IF prefs.latlong_traditional %] - <input type="checkbox" id="latlong" name="latlong_traditional" value="1" checked /> + <input type="checkbox" id="latlong" name="latlong_traditional" value="1" checked="1" /> [% ELSE %] <input type="checkbox" id="latlong" name="latlong_traditional" value="1" /> [% END %] @@ -41,7 +41,7 @@ <p> [% IF prefs.omit_help_links %] - <input type="checkbox" id="omit_help" name="omit_help_links" value="1" checked /> + <input type="checkbox" id="omit_help" name="omit_help_links" value="1" checked="1" /> [% ELSE %] <input type="checkbox" id="omit_help" name="omit_help_links" value="1" /> [% END %] @@ -50,7 +50,7 @@ <p> [% IF prefs.show_minor_edits_in_rc %] - <input type="checkbox" id="show_minor" name="show_minor_edits_in_rc" value="1" checked /> + <input type="checkbox" id="show_minor" name="show_minor_edits_in_rc" value="1" checked="1" /> [% ELSE %] <input type="checkbox" id="show_minor" name="show_minor_edits_in_rc" value="1" /> [% END %] @@ -59,7 +59,7 @@ <p> [% IF prefs.is_admin %] - <input type="checkbox" id="is_admin" name="is_admin" value="1" checked /> + <input type="checkbox" id="is_admin" name="is_admin" value="1" checked="1" /> [% ELSE %] <input type="checkbox" id="is_admin" name="is_admin" value="1" /> [% END %] @@ -120,7 +120,7 @@ </p> <input type="submit" value="Set it" class="form_button" /> - <input type="hidden" name="action" value="set_preferences"> + <input type="hidden" name="action" value="set_preferences" /> [% IF return_to_url %] <input type="hidden" name="return_to_url" value="[% return_to_url | html %]" />

10 years, 9 months

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

openguides-commits December 2012