#132: Standardise pages -------------------------+-------------------------------------------------- Reporter: cds | Owner: dom Type: enhancement | Status: new Priority: low | Milestone: Component: openguides | Version: svn Severity: trivial | Keywords: -------------------------+-------------------------------------------------- Different pages seem to use templates differently - the history pages doesn't have a #content - the edit page doesn't even have a navbar! It would be a lot easier to customise if it was all standardised.
#132: Standardise pages -------------------------+-------------------------------------------------- Reporter: cds | Owner: cds Type: enhancement | Status: new Priority: low | Milestone: 0.57 Component: openguides | Version: svn Severity: trivial | Resolution: Keywords: | -------------------------+-------------------------------------------------- Changes (by cds):
* milestone: => 0.57 * owner: dom => cds
Comment:
I've gone ahead and taken this - merely because I've fixed it myself, so can upload the new template files.
#132: Standardise pages -------------------------+-------------------------------------------------- Reporter: cds | Owner: dom Type: enhancement | Status: assigned Priority: low | Milestone: 0.57 Component: openguides | Version: svn Severity: trivial | Resolution: Keywords: | -------------------------+-------------------------------------------------- Changes (by dom):
* status: new => assigned * owner: cds => dom
#132: Standardise pages -------------------------+-------------------------------------------------- Reporter: cds | Owner: dom Type: enhancement | Status: assigned Priority: low | Milestone: 0.57 Component: openguides | Version: svn Severity: trivial | Resolution: Keywords: patch | -------------------------+-------------------------------------------------- Changes (by dom):
* keywords: => patch
#132: Standardise pages -------------------------+-------------------------------------------------- Reporter: cds | Owner: dom Type: enhancement | Status: assigned Priority: low | Milestone: 0.57 Component: openguides | Version: svn Severity: trivial | Resolution: Keywords: patch | -------------------------+-------------------------------------------------- Comment (by dom):
Note for self: the attached templates are based on 0.56, so diff against [810].
#132: Standardise pages -------------------------+-------------------------------------------------- Reporter: cds | Owner: dom Type: enhancement | Status: closed Priority: low | Milestone: 0.57 Component: openguides | Version: svn Severity: trivial | Resolution: fixed Keywords: patch | -------------------------+-------------------------------------------------- Changes (by dom):
* resolution: => fixed * status: assigned => closed
Comment:
(In [849]) Tidies up various template bugs (closes #132, #133)
#132: Standardise pages -------------------------+-------------------------------------------------- Reporter: cds | Owner: dom Type: enhancement | Status: reopened Priority: low | Milestone: 0.57 Component: openguides | Version: svn Severity: trivial | Resolution: Keywords: patch | -------------------------+-------------------------------------------------- Changes (by cds):
* resolution: fixed => * status: closed => reopened
Comment:
I'm going to reopen this, since there's still issues with the templates, such as the seemingly random switch between h1, h2, and centre aligned page titles, the edit form (which seems to break whenever there's space on the left for the sidebar, which there is - probably my fault), and the footer licence info.
#132: Standardise pages -------------------------+-------------------------------------------------- Reporter: cds | Owner: dom Type: enhancement | Status: reopened Priority: low | Milestone: 0.57 Component: openguides | Version: svn Severity: trivial | Resolution: Keywords: patch | -------------------------+-------------------------------------------------- Comment (by dom):
Clair,
I applied some of your changes, but other changes were not suitable for inclusion due to their arbitrarily changing existing styles and other customisations. It's possible that I missed some changes that should have gone in as they were tied up with such changes.
Please can you be more specific about what you think is wrong with the current templates, preferably as a patch against SVN.
#132: Standardise pages -------------------------+-------------------------------------------------- Reporter: cds | Owner: dom Type: enhancement | Status: reopened Priority: low | Milestone: 0.57 Component: openguides | Version: svn Severity: trivial | Resolution: Keywords: patch | -------------------------+-------------------------------------------------- Comment (by nick):
(In [869]) Fix space after licence name. References #132
#132: Standardise pages -------------------------+-------------------------------------------------- Reporter: cds | Owner: dom Type: enhancement | Status: reopened Priority: low | Milestone: 0.57 Component: openguides | Version: svn Severity: trivial | Resolution: Keywords: patch | -------------------------+-------------------------------------------------- Comment (by cds):
I understand why some changes weren't made, which isn't a problem. Those that I'm thinking of are: * The space after the licence name problem * The <br> before the footer... this leaves a gap which may not be wanted, and could easily be implemented by a clear=both in the CSS * I think the most common links could be put into the navbar, rather than the bottom of the node name. * The new RSS links for the category list, recent changes etc, aren't inside the maincontent div, which messes up things. * I'm not so sure about the choice of <h1>/<h2>. It appears some pages are h1, while some are h2. Although I might be missing out a reasoning behind.
I realise some of these are new to the latest version, so I'm not saying I'm reopening this ticket because all of my changes aren't included. Far from it :)
#132: Standardise pages -------------------------+-------------------------------------------------- Reporter: cds | Owner: dom Type: enhancement | Status: reopened Priority: low | Milestone: Component: openguides | Version: svn Severity: trivial | Resolution: Keywords: patch | -------------------------+-------------------------------------------------- Changes (by dom):
* milestone: 0.58 =>
openguides-tickets@lists.openguides.org