#212: Uninitialized variable warning in t/70_admin_home ------------------------+--------------------------------------------------- Reporter: dom | Owner: Nobody Type: defect | Status: new Priority: normal | Milestone: Component: openguides | Version: svn Severity: normal | Keywords: ------------------------+--------------------------------------------------- t/70_admin_home....................ok 1/12Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959.
#212: Uninitialized variable warning in t/70_admin_home ------------------------+--------------------------------------------------- Reporter: dom | Owner: Nobody Type: defect | Status: new Priority: normal | Milestone: Component: openguides | Version: svn Severity: normal | Resolution: Keywords: | ------------------------+--------------------------------------------------- Old description:
t/70_admin_home....................ok 1/12Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959.
New description:
{{{ t/70_admin_home....................ok 1/12Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. Use of uninitialized value in concatenation (.) or string at /home/dom/working/openguides/trunk/blib/lib/OpenGuides.pm line 1959. }}}
#212: Uninitialized variable warning in t/70_admin_home ------------------------+--------------------------------------------------- Reporter: dom | Owner: andrewb Type: defect | Status: assigned Priority: normal | Milestone: Component: openguides | Version: svn Severity: normal | Resolution: Keywords: | ------------------------+--------------------------------------------------- Changes (by andrewb):
* status: new => assigned * owner: Nobody => andrewb
#212: Uninitialized variable warning in t/70_admin_home -----------------------------------------+---------------------------------- Reporter: dom | Owner: andrewb Type: defect | Status: assigned Priority: normal | Milestone: Component: openguides | Version: svn Severity: normal | Resolution: Keywords: hackfestsummer2007-reviewed | -----------------------------------------+---------------------------------- Changes (by Kake):
* keywords: => hackfestsummer2007-reviewed
#212: Uninitialized variable warning in t/70_admin_home -----------------------------------------+---------------------------------- Reporter: dom | Owner: andrewb Type: defect | Status: assigned Priority: normal | Milestone: Component: openguides | Version: svn Severity: normal | Resolution: Keywords: hackfestsummer2007-reviewed | -----------------------------------------+---------------------------------- Comment (by andrewb):
{{{ 47: # Test the tt vars 48: my %ttvars = eval { 49: $guide->display_admin_interface( return_tt_vars=> 1 ); 50 };
sub display_admin_interface { ...... $node->{'revert_user_url'} = $script_name . "?action=revert_user" . ";username=".$node->{metadata}->{username}->[0];
}}} $node->{metadata}->{username} is not defined
{{{ 0 HASH(0x94cffe4) 'last_modified' => '2007-06-10 15:45:36' 'metadata' => HASH(0x949b0a4) 'category' => ARRAY(0x94cf1c8) 0 'Locales' 'moderate' => 0 'moderation_url' => 'wiki.cgi?action=set_moderation;id=Locale_Bar' 'name' => 'Locale Bar' 'version' => 2 'versions_url' => 'wiki.cgi?action=list_all_versions;id=Locale_Bar' 'view_url' => 'wiki.cgi?id=Locale_Bar' }}}
#212: Uninitialized variable warning in t/70_admin_home -----------------------------------------+---------------------------------- Reporter: dom | Owner: andrewb Type: defect | Status: assigned Priority: normal | Milestone: Component: openguides | Version: svn Severity: normal | Resolution: Keywords: hackfestsummer2007-reviewed | -----------------------------------------+---------------------------------- Comment (by andrewb):
I have changed the use of $wiki->write_node to OpenGuides::Test->write_data This creates a username, which the write_node routine did not.
One side effect is that write_data auto creates categories. so the following test has changed {{{ +is( scalar @{$ttvars{'categories'}}, 2, "Right number of categories" ); }}} Could this be recorded in the change history
#212: Uninitialized variable warning in t/70_admin_home -----------------------------------------+---------------------------------- Reporter: dom | Owner: andrewb Type: defect | Status: closed Priority: normal | Milestone: Component: openguides | Version: svn Severity: normal | Resolution: fixed Keywords: hackfestsummer2007-reviewed | -----------------------------------------+---------------------------------- Changes (by kake):
* status: assigned => closed * resolution: => fixed
Comment:
(In [1062]) Apply Andrew's patch, fixes #212 (uninitialised value warnings in test 70). Incidental change: use OpenGuides::Test->write_data instead of Wiki::Toolkit->write_node, hence change in number at line 59, since OpenGuides::Test autocreates categories and locales and Wiki::Toolkit doesn't.
openguides-tickets@lists.openguides.org
-
OpenGuides