#63: RecentChanges view does not set not_editable tt_var -------------------------------+-------------------------------------------- Reporter: ChristopherSchmidt | Owner: dom Type: defect | Status: new Priority: normal | Component: openguides Version: svn | Severity: normal Keywords: | -------------------------------+-------------------------------------------- On RecentChanges view, the not_editable variable is not set, so an "edit" link is presented for the node, for which content will never be seen because of special casing in the OG code.
#63: RecentChanges view does not set not_editable tt_var ---------------------------------+------------------------------------------ Reporter: ChristopherSchmidt | Owner: dom Type: defect | Status: new Priority: normal | Component: openguides Version: svn | Severity: normal Resolution: | Keywords: ---------------------------------+------------------------------------------ Comment (by ChristopherSchmidt):
This patch sets the not_editable variable for the RecentChanges node.
#63: RecentChanges view does not set not_editable tt_var ---------------------------------+------------------------------------------ Reporter: ChristopherSchmidt | Owner: dom Type: defect | Status: new Priority: normal | Component: openguides Version: svn | Severity: normal Resolution: | Keywords: ---------------------------------+------------------------------------------ Comment (by earle):
Are you sure? RecentChanges seems to be editable to me (e.g., http://london.openguides.org/index.cgi?id=RecentChanges;action=edit).
#63: RecentChanges view does not set not_editable tt_var ---------------------------------+------------------------------------------ Reporter: ChristopherSchmidt | Owner: dom Type: defect | Status: new Priority: normal | Component: openguides Version: svn | Severity: normal Resolution: | Keywords: ---------------------------------+------------------------------------------ Comment (by ChristopherSchmidt):
Well, I don't know what's different about you, but I get:
http://boston.openguides.org/?RecentChanges with http://boston.openguides.org/?id=RecentChanges;action=edit
Maybe I missed something in updating my code to the latest version...
#63: RecentChanges view does not set not_editable tt_var --------------------------------+------------------------------------------- Reporter: ChristopherSchmidt | Owner: dom Type: defect | Status: new Priority: normal | Milestone: Component: openguides | Version: svn Severity: normal | Resolution: Keywords: check | --------------------------------+------------------------------------------- Changes (by dom):
* keywords: => check
#63: RecentChanges view does not set not_editable tt_var --------------------------------+------------------------------------------- Reporter: ChristopherSchmidt | Owner: dom Type: defect | Status: assigned Priority: normal | Milestone: Component: openguides | Version: svn Severity: normal | Resolution: Keywords: check | --------------------------------+------------------------------------------- Changes (by dom):
* status: new => assigned
Comment:
I've checked london, oxford and boston and none display the node content. So I think it's correct that the not_editable flag needs setting here.
#63: RecentChanges view does not set not_editable tt_var --------------------------------+------------------------------------------- Reporter: ChristopherSchmidt | Owner: dom Type: defect | Status: closed Priority: normal | Milestone: Component: openguides | Version: svn Severity: normal | Resolution: fixed Keywords: check | --------------------------------+------------------------------------------- Changes (by dom):
* resolution: => fixed * status: assigned => closed
Comment:
(In [862]) RecentChanges is not editable (closes #63)
openguides-tickets@lists.openguides.org