#23: Ignore null changes ------------------------+--------------------------------------------------- Reporter: dom | Owner: tgj Type: defect | Status: assigned Priority: normal | Milestone: Component: openguides | Version: Severity: normal | Resolution: Keywords: patch | ------------------------+--------------------------------------------------- Changes (by tgj):

* keywords: => patch

Comment:

Confirmed that two consecutive versions with no changes do have the same checksum. So it's not that the checksum includes irrelevant metadata, but rather that the checksum isn't checked.

Attached patch is just a simple check for an identical checksum in Wiki::Toolkit::Store::Database. If the checksum is identical, the change is aborted.

The included test works okay. Haven't tested the patch's interoperation with openguides, but it looks like the (null) change will be silently rejected (no indication given to user). To improve this would need an API change for Wiki Toolkit to indicate that a change has been declined and provide a reason why. Still, this patch might be an improvement on the current situation.