From bob@randomness.org.uk Thu Jun 26 16:51:20 2008 From: Bob Walker To: openguides-dev@lists.openguides.org Subject: Re: [OGDev] Universal edit button Date: Thu, 26 Jun 2008 16:47:55 +0100 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1794334173851146628==" --===============1794334173851146628== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Wed, 25 Jun 2008, Bob Walker wrote: > On Wed, 25 Jun 2008, Kake L Pugh wrote: > >> On Wed 25 Jun 2008, Bob Walker wrote: >>> since its a 3 line patch. >>> find it attached. >> >> Tests please! >> > > bah. well if any of the current tests actually checked the output in the > i may have added anohter one. wel i managed to hack a couple of tests together. -- Bob Walker http://london.randomness.org.uk - http://tech.randomness.org.uk http://rwc.randomness.org.uk - http://londonjoinery.com for great beery justice! - meh! bah! indeeed! --===============1794334173851146628== Content-Type: text/plain Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="universaleditandtest.diff" MIME-Version: 1.0 SW5kZXg6IHRlbXBsYXRlcy9oZWFkZXIudHQNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSB0ZW1wbGF0ZXMvaGVh ZGVyLnR0CShyZXZpc2lvbiAxMTc3KQ0KKysrIHRlbXBsYXRlcy9oZWFkZXIudHQJKHdvcmtpbmcg Y29weSkNCkBAIC01NSw2ICs1NSw5IEBADQogICBbJSBJRiBkZXRlcl9yb2JvdHMgJV0NCiAgICAg PG1ldGEgbmFtZT0icm9ib3RzIiBjb250ZW50PSJub2luZGV4LG5vZm9sbG93IiAvPg0KICAgWyUg RU5EICVdDQorICBbJSBVTkxFU1Mgbm90X2VkaXRhYmxlICVdDQorCTxsaW5rIHJlbD0iYWx0ZXJu YXRlIiB0eXBlPSJhcHBsaWNhdGlvbi93aWtpIiB0aXRsZT0iRWRpdCB0aGlzIHBhZ2UhIiBocmVm PSJbJSBzb3VyY2Vfc2l0ZSBvciBmdWxsX2NnaV91cmwgJV0/aWQ9WyUgbm9kZV9wYXJhbSAlXTth Y3Rpb249ZWRpdCI+DQorWyUgRU5EICVdDQogICBbJSBJRiBlbmFibGVfZ21hcHMgQU5EIGRpc3Bs YXlfZ29vZ2xlX21hcHMgQU5EIGdtYXBzX2FwaV9rZXkgJV0NCiAgICAgPHNjcmlwdCBzcmM9Imh0 dHA6Ly9tYXBzLmdvb2dsZS5jb20vbWFwcz9maWxlPWFwaSZhbXA7dj0yJmFtcDtrZXk9WyUgZ21h cHNfYXBpX2tleSAlXSIgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij48L3NjcmlwdD4NCiAgIFslIEVO RCAlXQ0KSW5kZXg6IHQvODVfdW5pdmVyc2FsX2VkaXQudA0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIHQvODVf dW5pdmVyc2FsX2VkaXQudAkocmV2aXNpb24gMCkNCisrKyB0Lzg1X3VuaXZlcnNhbF9lZGl0LnQJ KHJldmlzaW9uIDApDQpAQCAtMCwwICsxLDYxIEBADQordXNlIHN0cmljdDsNCit1c2UgT3Blbkd1 aWRlczsNCit1c2UgT3Blbkd1aWRlczo6VGVzdDsNCit1c2UgVGVzdDo6TW9yZTsNCit1c2UgV2lr aTo6VG9vbGtpdDo6U2V0dXA6OlNRTGl0ZTsNCisNCitldmFsIHsgcmVxdWlyZSBEQkQ6OlNRTGl0 ZTsgfTsNCitpZiAoICRAICkgew0KKyAgICBwbGFuIHNraXBfYWxsID0+ICJEQkQ6OlNRTGl0ZSBu b3QgaW5zdGFsbGVkIC0gbm8gZGF0YWJhc2UgdG8gdGVzdCB3aXRoIjsNCisgICAgZXhpdCAwOw0K K30NCisNCisNCitwbGFuIHRlc3RzID0+IDI7DQorDQorIyB0ZXN0IHRoYXQgYW4gZWRpdGFibGUg cGFnZSBnZXRzIHRoZSB1bml2ZXJzYWwgZWRpdCA8bGluaz4gYW5kIHRoYXQgYSBub24tZWRpdGFi bGUgb25lIGRvZXNudC4NCisNCitteSAoICRjb25maWcsICRndWlkZSwgJHdpa2ksICRjb29raWUs ICRvdXRwdXQgKTsNCisNCisjIENsZWFyIG91dCB0aGUgZGF0YWJhc2UgZnJvbSBhbnkgcHJldmlv dXMgcnVucy4NCit1bmxpbmsgInQvbm9kZS5kYiI7DQordW5saW5rIDx0L2luZGV4ZXMvKj47DQor V2lraTo6VG9vbGtpdDo6U2V0dXA6OlNRTGl0ZTo6c2V0dXAoIHsgZGJuYW1lID0+ICJ0L25vZGUu ZGIiIH0gKTsNCisNCisjIE1ha2UgYSBndWlkZS4NCiskY29uZmlnID0gT3Blbkd1aWRlczo6VGVz dC0+bWFrZV9iYXNpY19jb25maWc7DQorJGd1aWRlID0gT3Blbkd1aWRlcy0+bmV3KCBjb25maWcg PT4gJGNvbmZpZyApOw0KK215ICR3aWtpID0gJGd1aWRlLT53aWtpOw0KKw0KKyMgV3JpdGUgYSBu b2RlLg0KK09wZW5HdWlkZXM6OlRlc3QtPndyaXRlX2RhdGEoDQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgZ3VpZGUgPT4gJGd1aWRlLA0KKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIG5vZGUgID0+ICJSZWQgTGlvbiIsDQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICk7 DQorDQorJG91dHB1dCA9ICRndWlkZS0+ZGlzcGxheV9ub2RlKA0KKwkJCQkgaWQgPT4gIlJlZCBM aW9uIiwNCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybl9vdXRwdXQgPT4g MSwNCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICApOw0KK2xpa2UoICRvdXRwdXQsIHFy fDxsaW5rIHJlbD0iYWx0ZXJuYXRlIiB0eXBlPSJhcHBsaWNhdGlvbi93aWtpIiB0aXRsZT0iRWRp dCB0aGlzIHBhZ2UhInxtcywNCisJInVuaXZlcnNhbCBlZGl0IGxpbmsgcHJlc2VudCIpOw0KKw0K Kw0KK3VubGlrZSAoIGdldF9vdXRwdXQoJHdpa2ksICRjb25maWcpLCBxcnw8bGluayByZWw9ImFs dGVybmF0ZSIgdHlwZT0iYXBwbGljYXRpb24vd2lraSIgdGl0bGU9IkVkaXQgdGhpcyBwYWdlISJ8 bXMsDQorICAgICAgICAidW5pdmVyc2FsIGVkaXQgbGluayBub3QgcHJlc2VudCIpOw0KKw0KKw0K K3N1YiBnZXRfb3V0cHV0IHsNCisgICAgbXkgKCR3aWtpLCAkY29uZmlnKSA9IEBfOw0KKw0KKyAg ICByZXR1cm4gT3Blbkd1aWRlczo6VGVtcGxhdGUtPm91dHB1dCgNCisgICAgICAgIHdpa2kgICAg ICAgICA9PiAkd2lraSwNCisgICAgICAgIGNvbmZpZyAgICAgICA9PiAkY29uZmlnLA0KKyAgICAg ICAgdGVtcGxhdGUgICAgID0+ICJwcmVmZXJlbmNlcy50dCIsDQorICAgICAgICBub2hlYWRlcnMg ICAgPT4gMSwNCisgICAgICAgIHZhcnMgICAgICAgICA9PiB7DQorICAgICAgICAgICAgICAgICAg ICAgICAgICBub3RfZWRpdGFibGUgPT4gMSwNCisgICAgICAgICAgICAgICAgICAgICAgICAgIHNo b3dfZm9ybSAgICA9PiAxDQorICAgICAgICAgICAgICAgICAgICAgICAgfSwNCisgICAgKTsNCit9 DQo= --===============1794334173851146628==--