[OGDev] Saint Paul patches

[Chris Prather]

On Mon, Nov 27, 2006 at 06:43:29PM -0500, Christopher Schmidt wrote:
> On Mon, Nov 27, 2006 at 11:17:59PM +0000, Dominic Hargreaves wrote:
> > On Fri, Nov 24, 2006 at 04:02:39PM -0600, Chris Prather wrote:
> > > I'd done some patching to St. Paul and wanted to feed hte changes back. Tickets #154 and #155 in the Trac (http://dev.openguides.org) are both from work I'd done previously with St. Paul's guide.
> > > 
> > > #154 provides basic JSON support for nodes and indexes. The Wiki::Toolkit::Plugin::JSON uses either JSON.pm or JSON::Syck to produce the output. 
> 
> Some comments:
>  * Mixed tabs and spaces

Sorry about that, I can only blame work. It's the preferred style. I'll try to remember to fix my tidy settings in the future.

>  * Docs on the new modules are not updated

D'oh, I can fix those.

>  * Doesn't generate correct URLs: generates things like
>    boston.openguides.org/id=Home;version=5 instead of 
>    boston.openguides.org/?id=Home;version=5
>    (This was a relatively simple fix, but I can't recall what it was off
>    the top of my head.)

If you remember what it was, I can easily patch it. Otherwise I'll take a look at it tonight. This was a quick hack to get things into SaintPaul that I suspect I wrote when it was using Alias /index.cgi /.

-Chris
 
> Regards,
> -- 
> Christopher Schmidt
> Web Developer
> 
> -- 
> OpenGuides-Dev mailing list - OpenGuides-Dev at lists.openguides.org
> http://lists.openguides.org/cgi-bin/mailman/listinfo/openguides-dev